[PATCH] Driver: bifurcate extended and basic MSC versioning

[Alp Toker]

On 01/07/2014 23:07, Aaron Ballman wrote:
> On Tue, Jul 1, 2014 at 3:57 PM, Reid Kleckner <rnk at google.com> wrote:
>> On Tue, Jul 1, 2014 at 12:52 PM, Kim Gräsman <kim.grasman at gmail.com> wrote:
>>> I think Alp is refering to _MSC_FULL_VER from here:
>>> http://msdn.microsoft.com/en-us/library/b0084kay.aspx
>>>
>>> That said, I'm not sure this option is a perfect representation of that
>>> symbol.
>>>
>>> I don't like "extended version" either, so I'm going out on a limb:
>>> -fmsc-version-string?
> If it required quotes, like -fmsc-version-string="17.00" that might be
> reasonable.
>
>> -fmsc-dotted-version?
> That's an interesting choice.
>
> Another idea: -fmsc-compiler-version?

My order of preference, without strong feelings:

   -fmsc-full-version (nice searchability, alignment with one of the 
macros defined and MSDN docs)
   -fmsc-dotted-version (descriptive, even if the argument can sometimes 
be non-dotted)
   -fms-compiler-version (descriptive)

Dislikes:

   -fmsc-version-string
   -fmsc-extended-version.

And finally, here's one blue-sky suggestion that ties in with our 
existing -fms-compatibility option:

   -fms-compatibility-version

The first three all have benefits, while the actual one we want we can't 
have. Basically I'd just tie-break and choose the first, or the last in 
this list ;-)

Alp.




> (It's a shame we cannot make this work using just -fmsc-version...)
>
> ~Aaron
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

-- 
http://www.nuanti.com
the browser experts