r210295 - Remove old proposal notices

[Richard Smith]

On Thu, Jun 5, 2014 at 4:27 PM, Alp Toker <alp at nuanti.com> wrote:

>
> On 06/06/2014 02:17, Richard Smith wrote:
>
>  On Thu, Jun 5, 2014 at 3:11 PM, Alp Toker <alp at nuanti.com <mailto:
>> alp at nuanti.com>> wrote:
>>
>>     Author: alp
>>     Date: Thu Jun  5 17:11:20 2014
>>     New Revision: 210295
>>
>>     URL: http://llvm.org/viewvc/llvm-project?rev=210295&view=rev
>>     Log:
>>     Remove old proposal notices
>>
>>     Let's just go ahead and assume the answer was 'I do'
>>
>>
>> :)
>>
>> You can check what proposals have made it into the ABI here:
>>
>> http://mentorembedded.github.io/cxx-abi/abi.html
>>
>> For the ones that aren't in the ABI, having a comment explaining why
>> we're using them and where they come from is useful. None of these three
>> are in the ABI document yet; please back this out for now.
>>
>
> Okay. It's not clear what value was added from the way they're written,
> nor did the commit logs explain it (I actually checked before landing this).
>
> If I revert it's likely they'll just get cleaned up again given that we
> have policy against attribution of reporters/contributors.
>

This is a "citing a spec" case, not attribution (but I agree that's not
really clear from these comments). Sadly the Itanium ABI document itself
often lags behind cxx-abi-dev, so references to the mailing list are the
best we can do.


> As you know the back story could you do the honours and add them back with
> a little context (e.g. who proposed to whom, "this is not yet part of XYZ
> spec" etc.)?
>

I'm hoping John will update the ABI so this becomes unnecessary :)


> Thanks
> Alp.
>
>
>> John: any chance we could get the ABI document updated with these? (
>> http://sourcerytools.com/pipermail/cxx-abi-dev/2012-January/000024.html)
>>
>>     Modified:
>>         cfe/trunk/lib/AST/ItaniumMangle.cpp
>>         cfe/trunk/test/CodeGenCXX/mangle-template.cpp
>>
>>     Modified: cfe/trunk/lib/AST/ItaniumMangle.cpp
>>     URL:
>>     http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/
>> ItaniumMangle.cpp?rev=210295&r1=210294&r2=210295&view=diff
>>     ============================================================
>> ==================
>>     --- cfe/trunk/lib/AST/ItaniumMangle.cpp (original)
>>     +++ cfe/trunk/lib/AST/ItaniumMangle.cpp Thu Jun  5 17:11:20 2014
>>     @@ -2674,7 +2674,6 @@ recurse:
>>          llvm_unreachable("cannot mangle opaque value; mangling wrong
>>     thing?");
>>
>>        case Expr::InitListExprClass: {
>>     -    // Proposal by Jason Merrill, 2012-01-03
>>          Out << "il";
>>          const InitListExpr *InitList = cast<InitListExpr>(E);
>>          for (unsigned i = 0, e = InitList->getNumInits(); i != e; ++i)
>>     @@ -2739,7 +2738,6 @@ recurse:
>>          Out << '_';
>>          mangleType(New->getAllocatedType());
>>          if (New->hasInitializer()) {
>>     -      // Proposal by Jason Merrill, 2012-01-03
>>            if (New->getInitializationStyle() == CXXNewExpr::ListInit)
>>              Out << "il";
>>            else
>>     @@ -2825,7 +2823,6 @@ recurse:
>>          const CXXConstructExpr *CE = cast<CXXConstructExpr>(E);
>>          unsigned N = CE->getNumArgs();
>>
>>     -    // Proposal by Jason Merrill, 2012-01-03
>>          if (CE->isListInitialization())
>>            Out << "tl";
>>          else
>>
>>     Modified: cfe/trunk/test/CodeGenCXX/mangle-template.cpp
>>     URL:
>>     http://llvm.org/viewvc/llvm-project/cfe/trunk/test/
>> CodeGenCXX/mangle-template.cpp?rev=210295&r1=210294&r2=210295&view=diff
>>     ============================================================
>> ==================
>>     --- cfe/trunk/test/CodeGenCXX/mangle-template.cpp (original)
>>     +++ cfe/trunk/test/CodeGenCXX/mangle-template.cpp Thu Jun  5
>>     17:11:20 2014
>>     @@ -147,7 +147,7 @@ namespace test10 {
>>        }
>>      }
>>
>>     -// Report from Jason Merrill on cxx-abi-dev, 2012.01.04.
>>     +// Report from cxx-abi-dev, 2012.01.04.
>>      namespace test11 {
>>        int cmp(char a, char b);
>>        template <typename T, int (*cmp)(T, T)> struct A {};
>>
>>
>>     _______________________________________________
>>     cfe-commits mailing list
>>     cfe-commits at cs.uiuc.edu <mailto:cfe-commits at cs.uiuc.edu>
>>     http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>
>>
>>
> --
> http://www.nuanti.com
> the browser experts
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140605/01032ee8/attachment.html>