<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, Jun 5, 2014 at 4:27 PM, Alp Toker <span dir="ltr"><<a href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
On 06/06/2014 02:17, Richard Smith wrote:<div class=""><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On Thu, Jun 5, 2014 at 3:11 PM, Alp Toker <<a href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a> <mailto:<a href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a>>> wrote:<br>
<br>
Author: alp<br>
Date: Thu Jun 5 17:11:20 2014<br>
New Revision: 210295<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=210295&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=210295&view=rev</a><br>
Log:<br>
Remove old proposal notices<br>
<br>
Let's just go ahead and assume the answer was 'I do'<br>
<br>
<br>
:)<br>
<br>
You can check what proposals have made it into the ABI here:<br>
<br>
<a href="http://mentorembedded.github.io/cxx-abi/abi.html" target="_blank">http://mentorembedded.github.<u></u>io/cxx-abi/abi.html</a><br>
<br>
For the ones that aren't in the ABI, having a comment explaining why we're using them and where they come from is useful. None of these three are in the ABI document yet; please back this out for now.<br>
</blockquote>
<br></div>
Okay. It's not clear what value was added from the way they're written, nor did the commit logs explain it (I actually checked before landing this).<br>
<br>
If I revert it's likely they'll just get cleaned up again given that we have policy against attribution of reporters/contributors.<br></blockquote><div><br></div><div>This is a "citing a spec" case, not attribution (but I agree that's not really clear from these comments). Sadly the Itanium ABI document itself often lags behind cxx-abi-dev, so references to the mailing list are the best we can do.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
As you know the back story could you do the honours and add them back with a little context (e.g. who proposed to whom, "this is not yet part of XYZ spec" etc.)?<br></blockquote><div><br></div><div>I'm hoping John will update the ABI so this becomes unnecessary :)</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Thanks<br>
Alp.<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5">
<br>
John: any chance we could get the ABI document updated with these? (<a href="http://sourcerytools.com/pipermail/cxx-abi-dev/2012-January/000024.html" target="_blank">http://sourcerytools.com/<u></u>pipermail/cxx-abi-dev/2012-<u></u>January/000024.html</a>)<br>
<br>
Modified:<br>
cfe/trunk/lib/AST/<u></u>ItaniumMangle.cpp<br>
cfe/trunk/test/CodeGenCXX/<u></u>mangle-template.cpp<br>
<br>
Modified: cfe/trunk/lib/AST/<u></u>ItaniumMangle.cpp<br>
URL:<br>
<a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/ItaniumMangle.cpp?rev=210295&r1=210294&r2=210295&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/cfe/trunk/lib/AST/<u></u>ItaniumMangle.cpp?rev=210295&<u></u>r1=210294&r2=210295&view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- cfe/trunk/lib/AST/<u></u>ItaniumMangle.cpp (original)<br>
+++ cfe/trunk/lib/AST/<u></u>ItaniumMangle.cpp Thu Jun 5 17:11:20 2014<br>
@@ -2674,7 +2674,6 @@ recurse:<br>
llvm_unreachable("cannot mangle opaque value; mangling wrong<br>
thing?");<br>
<br>
case Expr::InitListExprClass: {<br>
- // Proposal by Jason Merrill, 2012-01-03<br>
Out << "il";<br>
const InitListExpr *InitList = cast<InitListExpr>(E);<br>
for (unsigned i = 0, e = InitList->getNumInits(); i != e; ++i)<br>
@@ -2739,7 +2738,6 @@ recurse:<br>
Out << '_';<br>
mangleType(New-><u></u>getAllocatedType());<br>
if (New->hasInitializer()) {<br>
- // Proposal by Jason Merrill, 2012-01-03<br>
if (New->getInitializationStyle() == CXXNewExpr::ListInit)<br>
Out << "il";<br>
else<br>
@@ -2825,7 +2823,6 @@ recurse:<br>
const CXXConstructExpr *CE = cast<CXXConstructExpr>(E);<br>
unsigned N = CE->getNumArgs();<br>
<br>
- // Proposal by Jason Merrill, 2012-01-03<br>
if (CE->isListInitialization())<br>
Out << "tl";<br>
else<br>
<br>
Modified: cfe/trunk/test/CodeGenCXX/<u></u>mangle-template.cpp<br>
URL:<br>
<a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/mangle-template.cpp?rev=210295&r1=210294&r2=210295&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/cfe/trunk/test/<u></u>CodeGenCXX/mangle-template.<u></u>cpp?rev=210295&r1=210294&r2=<u></u>210295&view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- cfe/trunk/test/CodeGenCXX/<u></u>mangle-template.cpp (original)<br>
+++ cfe/trunk/test/CodeGenCXX/<u></u>mangle-template.cpp Thu Jun 5<br>
17:11:20 2014<br>
@@ -147,7 +147,7 @@ namespace test10 {<br>
}<br>
}<br>
<br>
-// Report from Jason Merrill on cxx-abi-dev, 2012.01.04.<br>
+// Report from cxx-abi-dev, 2012.01.04.<br>
namespace test11 {<br>
int cmp(char a, char b);<br>
template <typename T, int (*cmp)(T, T)> struct A {};<br>
<br>
<br>
______________________________<u></u>_________________<br>
cfe-commits mailing list<br></div></div>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a> <mailto:<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.<u></u>edu</a>><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/cfe-commits</a><br>
<br>
<br><span class="HOEnZb"><font color="#888888">
</font></span></blockquote><span class="HOEnZb"><font color="#888888">
<br>
-- <br>
<a href="http://www.nuanti.com" target="_blank">http://www.nuanti.com</a><br>
the browser experts<br>
<br>
</font></span></blockquote></div><br></div></div>