r209708 - Move the logic for testing for namespace std into one location. This check can

[Jordan Rose]

On May 29, 2014, at 20:24 , Richard Smith <richard at metafoo.co.uk> wrote:

> On Tue, May 27, 2014 at 8:22 PM, Jordan Rose <jordan_rose at apple.com> wrote:
> Wow, this is showing me how many of the analyzer checks aren't handling namespaces within std.
> 
> I think they might all be correct: the last two walk up to the outermost namespace before checking whether it's 'std'. The first of the three is looking for exactly 'std::string'.

Ah, for some reason I was ignoring the rest of the function.

The LLVMConventionsChecker is way out of date, but checking for "std::string" exactly isn't going to work with libc++. We should probably just remove that checker until someone feels like reviving it and starting to use it regularly.

Jordan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140530/5693c931/attachment.html>