<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On May 29, 2014, at 20:24 , Richard Smith <<a href="mailto:richard@metafoo.co.uk">richard@metafoo.co.uk</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, May 27, 2014 at 8:22 PM, Jordan Rose<span class="Apple-converted-space"> </span><span dir="ltr"><<a href="mailto:jordan_rose@apple.com" target="_blank">jordan_rose@apple.com</a>></span><span class="Apple-converted-space"> </span>wrote:<br><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;"><div style="word-wrap: break-word;">Wow, this is showing me how many of the analyzer checks aren't handling namespaces<span class="Apple-converted-space"> </span><i>within</i> std.</div></blockquote><div><br></div><div>I think they might all be correct: the last two walk up to the outermost namespace before checking whether it's 'std'. The first of the three is looking for exactly 'std::string'.</div></div></div></div></div></blockquote><br></div><div>Ah, for some reason I was ignoring the rest of the function.</div><div><br></div><div>The LLVMConventionsChecker is way out of date, but checking for "std::string" exactly isn't going to work with libc++. We should probably just remove that checker until someone feels like reviving it and starting to use it regularly.</div><div><br></div><div>Jordan</div></body></html>