[PATCH] Remove limits on the number of fix-it hints and ranges in the DiagnosticsEngine.

Alp Toker alp at nuanti.com
Thu May 22 13:07:23 PDT 2014


Thanks for the CC! I'm away from the build today but what I've seen of the change looks correct and welcome. If Richard has looked at this please do go ahead. 

Cheers
Alp.

On 22 May 2014 22:26:41 EEST, Alexander Kornienko <alexfh at google.com> wrote:
>Alp, you're not on reviews.llvm.org, so I'm cc-ing you here, as you may
>want to look at this.
>
>
>On Thu, May 22, 2014 at 9:23 PM, Alexander Kornienko
><alexfh at google.com>wrote:
>
>> Hi rsmith,
>>
>> The limits on the number of fix-it hints and ranges attached to a
>> diagnostic are arbitrary and don't apply universally to all users of
>the
>> DiagnosticsEngine. The way the limits are enforced may lead to
>diagnostics
>> generating invalid sets of fixes. I suggest removing the limits,
>which
>> will also
>> simplify the implementation.
>>
>> http://reviews.llvm.org/D3879
>>
>> Files:
>>   .gitignore
>>   include/clang/Basic/Diagnostic.h
>>   include/clang/Basic/PartialDiagnostic.h
>>   lib/Basic/Diagnostic.cpp
>>   lib/Format/Format.cpp
>>   lib/Frontend/SerializedDiagnosticPrinter.cpp
>>   lib/Frontend/TextDiagnosticPrinter.cpp
>>   lib/Lex/LiteralSupport.cpp
>>   lib/Lex/PPMacroExpansion.cpp
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140522/31114851/attachment.html>


More information about the cfe-commits mailing list