<html><head></head><body>Thanks for the CC! I'm away from the build today but what I've seen of the change looks correct and welcome. If Richard has looked at this please do go ahead. <br>
<br>
Cheers<br>
Alp.<br><br><div class="gmail_quote">On 22 May 2014 22:26:41 EEST, Alexander Kornienko <alexfh@google.com> wrote:<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div dir="ltr">Alp, you're not on <a href="http://reviews.llvm.org">reviews.llvm.org</a>, so I'm cc-ing you here, as you may want to look at this.<br /><div class="gmail_extra"><br /><br /><div class="gmail_quote">On Thu, May 22, 2014 at 9:23 PM, Alexander Kornienko <span dir="ltr"><<a href="mailto:alexfh@google.com" target="_blank">alexfh@google.com</a>></span> wrote:<br />
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi rsmith,<br />
<br />
The limits on the number of fix-it hints and ranges attached to a<br />
diagnostic are arbitrary and don't apply universally to all users of the<br />
DiagnosticsEngine. The way the limits are enforced may lead to diagnostics<br />
generating invalid sets of fixes. I suggest removing the limits, which will also<br />
simplify the implementation.<br />
<br />
<a href="http://reviews.llvm.org/D3879" target="_blank">http://reviews.llvm.org/D3879</a><br />
<br />
Files:<br />
.gitignore<br />
include/clang/Basic/Diagnostic.h<br />
include/clang/Basic/PartialDiagnostic.h<br />
lib/Basic/Diagnostic.cpp<br />
lib/Format/Format.cpp<br />
lib/Frontend/SerializedDiagnosticPrinter.cpp<br />
lib/Frontend/TextDiagnosticPrinter.cpp<br />
lib/Lex/LiteralSupport.cpp<br />
lib/Lex/PPMacroExpansion.cpp<br />
</blockquote></div><br />
</div></div>
</blockquote></div></body></html>