r208722 - Add a requires for the arm-registered-target needed by this test as

Nico Weber thakis at chromium.org
Tue May 13 13:26:00 PDT 2014


On Tue, May 13, 2014 at 1:21 PM, Eric Christopher <echristo at gmail.com>wrote:

> On Tue, May 13, 2014 at 1:20 PM, Rafael EspĂ­ndola
> <rafael.espindola at gmail.com> wrote:
> > On 13 May 2014 16:09, Eric Christopher <echristo at gmail.com> wrote:
> >> Also as a note, driver tests shouldn't require registered targets if
> >> they're just checking command lines. Also, no clang test should
> >> require a registered target. I'm not sure why some do at the moment.
> >
> > This is a case where the -cc1 test requiring asm printing is somewhat
> > reasonable. I don't think we have a better way to check that a codegen
> > option passed to -cc1 is being used.
> >
>
> Right. We should only test that we've passed it. Make no claims about
> it working :)
>

Why is that? Isn't it more interesting to test that -masm=intel actually
produces intel asm, instead of testing some implementation detail for how
that's done?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140513/cdb2a2a5/attachment.html>


More information about the cfe-commits mailing list