[PATCH] [compiler-rt] Move arm vfp builtins to their own folder

[Alexey Samsonov]

On Mon, May 12, 2014 at 5:45 PM, Jon Roelofs <jonathan at codesourcery.com>wrote:

> ================
> Comment at: lib/builtins/arm/vfp/adddf3vfp.S:10
> @@ -9,3 +9,3 @@
>
> -#include "../assembly.h"
> +#include "../../assembly.h"
>
> ----------------
> Saleem Abdulrasool wrote:
> > Im tempted to say that we should adjust the CPPFLAGS to include
> $(top_srcdir)/lib/builtins in the include search path and make this into:
> >
> >     #include "assembly.h"
> >
> > We certainly do similar things on the LLVM side where we assume that
> $(top_srcdir)/include is in the search path for headers.  I don't think
> that the minor discomfort of gf no longer working in vim is a huge loss.
> Yeah, I'm not a huge fan of '../' in include paths either, but I don't
> feel comfortable enough with compiler-rt's makefiles to make that
> change.... they're quite complicated :)
>

You'll also have to change CMake build system :)
Currently Makefile build system has "/compiler-rt/lib" in its include
paths, so you can probably include the headers as "builtins/assembly.h".



>
> http://reviews.llvm.org/D3731
>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>



-- 
Alexey Samsonov, Mountain View, CA
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140512/05c26533/attachment.html>