[PATCH] [compiler-rt] Move arm vfp builtins to their own folder

Jon Roelofs jonathan at codesourcery.com
Mon May 12 17:45:15 PDT 2014


================
Comment at: lib/builtins/arm/vfp/adddf3vfp.S:10
@@ -9,3 +9,3 @@
 
-#include "../assembly.h"
+#include "../../assembly.h"
 
----------------
Saleem Abdulrasool wrote:
> Im tempted to say that we should adjust the CPPFLAGS to include $(top_srcdir)/lib/builtins in the include search path and make this into:
> 
>     #include "assembly.h"
> 
> We certainly do similar things on the LLVM side where we assume that $(top_srcdir)/include is in the search path for headers.  I don't think that the minor discomfort of gf no longer working in vim is a huge loss.
Yeah, I'm not a huge fan of '../' in include paths either, but I don't feel comfortable enough with compiler-rt's makefiles to make that change.... they're quite complicated :)

http://reviews.llvm.org/D3731






More information about the cfe-commits mailing list