[PATCH] Bitrig uses TLS

Richard Smith richard at metafoo.co.uk
Thu May 1 15:05:37 PDT 2014


We should at least have a test that we don't reject TLS for Bitrig. The
right place to add such a test is test/Sema/tls.c

On Thu, May 1, 2014 at 2:55 PM, Reid Kleckner <rnk at google.com> wrote:

> I wouldn't test it, since the codepaths are covered by other targets.  You
> can drop the assignment entirely.  The default value of TLSSupported is
> true.
>
>
> On Thu, May 1, 2014 at 1:49 PM, Patrick Wildt <mail at patrick-wildt.de>wrote:
>
>> Hi,
>>
>> Bitrig now does TLS, so it should be marked as supported in the
>> TargetInfo.
>>
>> Does this patch need a test?  Is there some test I can add
>> a Bitrig target to?
>>
>> \Patrick
>>
>> diff --git a/lib/Basic/Targets.cpp b/lib/Basic/Targets.cpp
>> index 6fdd0d0..387e3d9 100644
>> --- a/lib/Basic/Targets.cpp
>> +++ b/lib/Basic/Targets.cpp
>> @@ -445,7 +445,7 @@ protected:
>>  public:
>>    BitrigTargetInfo(const llvm::Triple &Triple) :
>> OSTargetInfo<Target>(Triple) {
>>      this->UserLabelPrefix = "";
>> -    this->TLSSupported = false;
>> +    this->TLSSupported = true;
>>      this->MCountName = "__mcount";
>>    }
>>  };
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140501/a3c362e6/attachment.html>


More information about the cfe-commits mailing list