[PATCH] Bitrig uses TLS

Patrick Wildt mail at patrick-wildt.de
Thu May 1 15:04:47 PDT 2014


Oh, thanks.  Well, that makes it even easier!

diff --git a/lib/Basic/Targets.cpp b/lib/Basic/Targets.cpp
index 6fdd0d0..a514466 100644
--- a/lib/Basic/Targets.cpp
+++ b/lib/Basic/Targets.cpp
@@ -445,7 +445,6 @@ protected:
 public:
   BitrigTargetInfo(const llvm::Triple &Triple) : OSTargetInfo<Target>(Triple) {
     this->UserLabelPrefix = "";
-    this->TLSSupported = false;
     this->MCountName = "__mcount";
   }
 };


On Thu, May 01, 2014 at 02:55:27PM -0700, Reid Kleckner wrote:
> I wouldn't test it, since the codepaths are covered by other targets.  You
> can drop the assignment entirely.  The default value of TLSSupported is
> true.
> 
> 
> On Thu, May 1, 2014 at 1:49 PM, Patrick Wildt <mail at patrick-wildt.de> wrote:
> 
> > Hi,
> >
> > Bitrig now does TLS, so it should be marked as supported in the
> > TargetInfo.
> >
> > Does this patch need a test?  Is there some test I can add
> > a Bitrig target to?
> >
> > \Patrick
> >
> > diff --git a/lib/Basic/Targets.cpp b/lib/Basic/Targets.cpp
> > index 6fdd0d0..387e3d9 100644
> > --- a/lib/Basic/Targets.cpp
> > +++ b/lib/Basic/Targets.cpp
> > @@ -445,7 +445,7 @@ protected:
> >  public:
> >    BitrigTargetInfo(const llvm::Triple &Triple) :
> > OSTargetInfo<Target>(Triple) {
> >      this->UserLabelPrefix = "";
> > -    this->TLSSupported = false;
> > +    this->TLSSupported = true;
> >      this->MCountName = "__mcount";
> >    }
> >  };
> > _______________________________________________
> > cfe-commits mailing list
> > cfe-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> >



More information about the cfe-commits mailing list