[PATCH] do not warn about unknown pragmas in modes that do not handle them (pr9537) #2

Richard Smith richard at metafoo.co.uk
Thu May 1 09:03:12 PDT 2014


On 1 May 2014 06:01, "Lubos Lunak" <l.lunak at centrum.cz> wrote:
>
> On Sunday 13 of April 2014, Richard Smith wrote:
> > Please also add a test for the #pragma STDC case. Other than that, LGTM.
> > Thanks!
>
>  I cannot add a test for it, as such. The problem was hitting an assert in
> Clang's code during setup, it didn't depend on any specific input (I only
> didn't encounter it because of not having assert build when testing it
> originally). If this kind of problem ever shows up, it'll be triggered by
a
> number of already existing tests (any that use the call, e.g. all
> of -frewrite-includes tests).
>
>  So I've committed the patch as it was. In case I misunderstood and you
can
> explain what you meant exactly, I can add what would be necessary.

No, that's fine, thanks!

> > On Fri, Apr 4, 2014 at 3:32 AM, Lubos Lunak <l.lunak at centrum.cz> wrote:
> > >  This is a re-send of the patch from
> > >
> > >
http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20131202/09469
> > >6.html, which went without any answers. As can be seen in that mail,
the
> > > original version of the patch has already been committed as r196372
but
> > > was then reverted because of a problem that this new version solves.
>
> --
>  Lubos Lunak
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140501/e0a8d1ef/attachment.html>


More information about the cfe-commits mailing list