[PATCH] #pragma vectorize

[Tyler Nowicki]

+Alexander and Douglas

Sorry you guys dropped off the cc for some reason.

On Apr 29, 2014, at 3:51 PM, Tyler Nowicki <tnowicki at apple.com> wrote:

> Hi,
> 
> I’ve updated the patch with the FIXME. I’ve also added a separate test for the contradictory pragmas.
> 
> @Alexander: Since BalancedDelimiterTracker does not have any benefits and just adds unnecessary complexity I opted not to use it.
> 
> Thanks everyone for your feedback. Please review the updated patch.
> 
> Tyler
> 
> <pragma_loop-svn.patch>
> 
> On Apr 29, 2014, at 11:26 AM, Nadav Rotem <nrotem at apple.com> wrote:
> 
>> 
>> On Apr 29, 2014, at 11:24 AM, Hal Finkel <hfinkel at anl.gov> wrote:
>> 
>>> I'm fine with this as incremental progress, so long as the follow-up happens in the near term. Please add a FIXME describing what needs to change to support constant expressions (including use via template instantiation).
>> 
>> +1.  I also like the incremental approach, as long as we have bugzilla PRs to track. 
> 
> 
> On Apr 29, 2014, at 9:17 AM, Alexander Musman <alexander.musman at gmail.com> wrote:
> 
>> >>>
>> >>> ParsePragma.cpp:1619: // Read '('
>> >>> This looks like a good place to use BalancedDelimiterTracker for parsing '(' and ')’.
>> 
>> >>I don’t think it is needed. It isn’t used by any other #pragma directives and the syntax here is rather simple. What do you think would be the benefit?
>> 
>> This would improve consistency with the other places in clang where '(' and ')' are parsed. Otherwise it seems to be equivalent to handling '(' and ')' manually.
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140429/b99bf4f9/attachment.html>