<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div>+Alexander and Douglas</div><div><br></div><div>Sorry you guys dropped off the cc for some reason.</div><div><br></div><div><div>On Apr 29, 2014, at 3:51 PM, Tyler Nowicki <<a href="mailto:tnowicki@apple.com">tnowicki@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta http-equiv="Content-Type" content="text/html charset=windows-1252"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div>Hi,</div><div><br></div><div>I’ve updated the patch with the FIXME. I’ve also added a separate test for the contradictory pragmas.</div><div><br></div><div>@Alexander: Since <font face="arial, sans-serif"><span style="font-size: 12.800000190734863px;">BalancedDelimiterTracker does not have any </span></font><font face="arial, sans-serif" size="2">benefits</font><font face="arial, sans-serif" size="2"> and just adds unnecessary complexity I opted not to use it.</font></div><div><font face="arial, sans-serif" size="2"><br></font></div><div>Thanks everyone for your feedback. Please review the updated patch.</div><div><br></div><div>Tyler</div><div><br></div><div></div></div><span><pragma_loop-svn.patch></span><meta http-equiv="Content-Type" content="text/html charset=windows-1252"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div></div><br><div><div>On Apr 29, 2014, at 11:26 AM, Nadav Rotem <<a href="mailto:nrotem@apple.com">nrotem@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta http-equiv="Content-Type" content="text/html charset=us-ascii"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Apr 29, 2014, at 11:24 AM, Hal Finkel <<a href="mailto:hfinkel@anl.gov">hfinkel@anl.gov</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;">I'm fine with this as incremental progress, so long as the follow-up happens in the near term. Please add a FIXME describing what needs to change to support constant expressions (including use via template instantiation).</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"></blockquote></div><br><div>+1. I also like the incremental approach, as long as we have bugzilla PRs to track. </div></div></blockquote></div><br><div><div class="im" style="font-family: arial, sans-serif; font-size: 12.800000190734863px;"><div class="im"><br><div style="font-family: Helvetica; font-size: 12px;">On Apr 29, 2014, at 9:17 AM, Alexander Musman <<a href="mailto:alexander.musman@gmail.com">alexander.musman@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline" style="font-family: Helvetica; font-size: 12px;"><blockquote type="cite" style="font-family: Helvetica; font-size: 12px;"><div dir="ltr"><div class="im" style="font-family: arial, sans-serif; font-size: 12.800000190734863px;"><div class="im">>>><br>>>> ParsePragma.cpp:1619: // Read '('<br>>>> This looks like a good place to use BalancedDelimiterTracker for parsing '(' and ')’.<br><br></div><span style="color: rgb(34, 34, 34);">>>I don’t think it is needed. It isn’t used by any other #pragma directives and the syntax here is rather simple. What do you think would be the benefit?</span><br></div><div class="im" style="font-family: arial, sans-serif; font-size: 12.800000190734863px;"><span style="color: rgb(34, 34, 34);"><br></span></div><div class="im" style="font-family: arial, sans-serif; font-size: 12.800000190734863px;"><font color="#222222">This would improve consistency with the other places in clang where '(' and ')' are parsed. Otherwise it seems to be equivalent to handling '(' and ')' manually.</font></div></div></blockquote></div></div></div></div>_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits<br></blockquote></div><br></body></html>