r207392 - libclang: split out the documentation comment API

Dmitri Gribenko gribozavr at gmail.com
Mon Apr 28 01:19:00 PDT 2014


On Mon, Apr 28, 2014 at 9:09 AM, Alp Toker <alp at nuanti.com> wrote:
>
> On 28/04/2014 08:37, Dmitri Gribenko wrote:
>>
>> On Mon, Apr 28, 2014 at 8:16 AM, Alp Toker <alp at nuanti.com> wrote:
>>> When the implementation starts to add HTML5 rules and JavaScript
>>> validators
>>> in libclang(!) while the basic one-liner comment parsing isn't yet
>>> dogfoodable due to performance issues it's worth taking a step back.
>>> Seriously, let's fix this.
>>
>> Please don't conflate these issues.  HTML is an indivisible part of
>> Doxygen.  In fact, because of insufficient level of HTML semantic
>> analysis, Clang's implementation of comment parsing differs from
>> Doxygen (I can provide examples if required).
>
> Dmitri, if indeed HTML support is blocking your work, how about linking to a
> proper HTML library?

Any suggestions about an HTML parsing, validation and sanitizing
library that is widely available on unix systems?  When I did the
implementation, I made a survey and I did not found anything that
exposes enough of low-level HTML manipulation and semantic analysis
APIs that we need.

> The same goes to the other XML and HTML facilities in your implementation --
> it'd be amazing if we could cut back on wheel reinvention here.

We link against libxml for XML validation.  XML generation is faster
when done directly, without constructing a DOM first, so that is
exactly what we do.

> It's not realistic to incur such a dependency on the compiler or libclang so
> this is another great reason to expedite the layering fixes outlined and to
> split out the C API.

"Such a dependency" -- please clarify.

Dmitri

-- 
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/



More information about the cfe-commits mailing list