r207392 - libclang: split out the documentation comment API

[Alp Toker]

On 28/04/2014 08:37, Dmitri Gribenko wrote:
> On Mon, Apr 28, 2014 at 8:16 AM, Alp Toker <alp at nuanti.com> wrote:
>
>> Most of all I'm certain that ~20,000 LoC can be reduced for what boils down
>> to parsing a few comments and checking that param commands match the user's
>> function parameters.
> Given that I am the primary author of this code, I am skeptical of
> such claims.  Doxygen is complicated, non-trivial to parse, and
> non-uniform in its syntax and semantic rules.

I really appreciate that and I want to help get your work in the hands 
of more users. The goal is most certainly not to trivialise the work, 
but to see if there are ways to make it move faster :-)

>
>> When the implementation starts to add HTML5 rules and JavaScript validators
>> in libclang(!) while the basic one-liner comment parsing isn't yet
>> dogfoodable due to performance issues it's worth taking a step back.
>> Seriously, let's fix this.
> Please don't conflate these issues.  HTML is an indivisible part of
> Doxygen.  In fact, because of insufficient level of HTML semantic
> analysis, Clang's implementation of comment parsing differs from
> Doxygen (I can provide examples if required).

Dmitri, if indeed HTML support is blocking your work, how about linking 
to a proper HTML library?

The same goes to the other XML and HTML facilities in your 
implementation -- it'd be amazing if we could cut back on wheel 
reinvention here.

It's not realistic to incur such a dependency on the compiler or 
libclang so this is another great reason to expedite the layering fixes 
outlined and to split out the C API.

Cheers,
Alp.


-- 
http://www.nuanti.com
the browser experts