[PATCH] CodeGen: Emit warnings when dropping profile data during PGO
Justin Bogner
mail at justinbogner.com
Tue Apr 15 14:29:50 PDT 2014
"Duncan P. N. Exon Smith" <dexonsmith at apple.com> writes:
> On 2014-Apr-15, at 13:55, Justin Bogner <mail at justinbogner.com> wrote:
>
>> Justin Bogner <mail at justinbogner.com> writes:
>>> Bob Wilson <bob.wilson at apple.com> writes:
>>>>>> After some thought, I think the parallel with the -f name is
>>>>>> worthwhile. I've gone with profile-instr-dropped
>>>>>
>>>>> I might be bike shedding here, but is -Wprofile-instr-out-of-date
>>>>> better? That matches the actual message you went with below.
>>>>
>>>> Yes, I like -Wprofile-instr-out-of-date much better than -dropped.
>>>
>>> It's a bit long, but I don't have anything better. Sure.
>>
>> Oops, I never sent an updated patch! Is this okay to commit?
>>
>> <mismatch-once-per-tu-3.patch>
>
> LGTM. (That's a long warning, but I guess I asked for it...)
r206322
More information about the cfe-commits
mailing list