[PATCH] CodeGen: Emit warnings when dropping profile data during PGO

Duncan P. N. Exon Smith dexonsmith at apple.com
Tue Apr 15 14:13:04 PDT 2014

On 2014-Apr-15, at 13:55, Justin Bogner <mail at justinbogner.com> wrote:

> Justin Bogner <mail at justinbogner.com> writes:
>> Bob Wilson <bob.wilson at apple.com> writes:
>>>>> After some thought, I think the parallel with the -f name is
>>>>> worthwhile. I've gone with profile-instr-dropped
>>>> I might be bike shedding here, but is -Wprofile-instr-out-of-date
>>>> better?  That matches the actual message you went with below.
>>> Yes, I like -Wprofile-instr-out-of-date much better than -dropped.
>> It's a bit long, but I don't have anything better. Sure.
> Oops, I never sent an updated patch! Is this okay to commit?
> <mismatch-once-per-tu-3.patch>

LGTM.  (That's a long warning, but I guess I asked for it...)

More information about the cfe-commits mailing list