[PATCH] InstrProf: Calculate a better function hash
Duncan P. N. Exon Smith
dexonsmith at apple.com
Thu Apr 10 16:46:15 PDT 2014
On Apr 10, 2014, at 3:47, Chandler Carruth <chandlerc at google.com> wrote:
> Still looking at the patch but:
>
> Using hash values with the most significant bit set exposed a bug where
> unsigned values were read using strtol and strtoll. Changed to strtoul
> and strtoull to keep the tests passing.
>
> This bit is clearly correct, and I'm happy for it to get exercised once the final bits land. I would split this out into its own patch and go ahead and commit it. The hash change is better as a separate patch IMO.
r206001
More information about the cfe-commits
mailing list