r203624 - Be case sensitive when determining driver mode based on argv[0] except on Windows

Hans Wennborg hans at chromium.org
Wed Mar 12 09:14:57 PDT 2014


I've addressed this in r203668.

Thanks,
Hans

On Wed, Mar 12, 2014 at 5:32 AM, Dimitry Andric <dimitry at andric.com> wrote:
> I suggested _WIN32, because that is also used further down in the file (around line 448).  But if LLVM_ON_WIN32 is more correct, it should probably be used everywhere?
>
>
> On 12 Mar 2014, at 12:13, Anton Korobeynikov <anton at korobeynikov.info> wrote:
>
>>>   std::string ProgName(llvm::sys::path::stem(ArgVector[0]));
>>> +#ifdef _WIN32
>> It should definitely be LLVM_ON_WIN32 here
>>
>> --
>> With best regards, Anton Korobeynikov
>> Faculty of Mathematics and Mechanics, Saint Petersburg State University
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>



More information about the cfe-commits mailing list