r203624 - Be case sensitive when determining driver mode based on argv[0] except on Windows

Dimitry Andric dimitry at andric.com
Wed Mar 12 05:32:45 PDT 2014


I suggested _WIN32, because that is also used further down in the file (around line 448).  But if LLVM_ON_WIN32 is more correct, it should probably be used everywhere?

-Dimitry

On 12 Mar 2014, at 12:13, Anton Korobeynikov <anton at korobeynikov.info> wrote:

>>   std::string ProgName(llvm::sys::path::stem(ArgVector[0]));
>> +#ifdef _WIN32
> It should definitely be LLVM_ON_WIN32 here
> 
> -- 
> With best regards, Anton Korobeynikov
> Faculty of Mathematics and Mechanics, Saint Petersburg State University
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 203 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140312/5aa692ce/attachment.sig>


More information about the cfe-commits mailing list