r202437 - Remove an assertion that no longer holds. <rdar://problem/16135814>

[Bob Wilson]

I added a test case in r202468.

On Feb 27, 2014, at 4:45 PM, Richard Smith <richard at metafoo.co.uk> wrote:

> Is this covered by the existing test suite? If not, could you add a test case?
> 
> 
> On Thu, Feb 27, 2014 at 1:59 PM, Bob Wilson <bob.wilson at apple.com> wrote:
> Author: bwilson
> Date: Thu Feb 27 15:59:17 2014
> New Revision: 202437
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=202437&view=rev
> Log:
> Remove an assertion that no longer holds. <rdar://problem/16135814>
> 
> In r201528, I changed the PGO instrumentation counter for a "do" loop to not
> include the fall-through count. That fall-through count is included later, b
> it means that this assertion may fail for "do" loops.
> 
> Modified:
>     cfe/trunk/lib/CodeGen/CodeGenPGO.h
> 
> Modified: cfe/trunk/lib/CodeGen/CodeGenPGO.h
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CodeGenPGO.h?rev=202437&r1=202436&r2=202437&view=diff
> ==============================================================================
> --- cfe/trunk/lib/CodeGen/CodeGenPGO.h (original)
> +++ cfe/trunk/lib/CodeGen/CodeGenPGO.h Thu Feb 27 15:59:17 2014
> @@ -186,7 +186,6 @@ public:
>    /// within the region. The adjusted count, then, is the value of the counter
>    /// at the end of the region.
>    uint64_t getAdjustedCount() const {
> -    assert((Adjust > 0 || (uint64_t)(-Adjust) <= Count) && "Negative count");
>      return Count + Adjust;
>    }
> 
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140227/69948fb4/attachment.html>