<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">I added a test case in r202468.<div><br><div style=""><div>On Feb 27, 2014, at 4:45 PM, Richard Smith <<a href="mailto:richard@metafoo.co.uk">richard@metafoo.co.uk</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">Is this covered by the existing test suite? If not, could you add a test case?</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Feb 27, 2014 at 1:59 PM, Bob Wilson <span dir="ltr"><<a href="mailto:bob.wilson@apple.com" target="_blank">bob.wilson@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: bwilson<br>
Date: Thu Feb 27 15:59:17 2014<br>
New Revision: 202437<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=202437&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=202437&view=rev</a><br>
Log:<br>
Remove an assertion that no longer holds. <<a href="rdar://problem/16135814">rdar://problem/16135814</a>><br>
<br>
In r201528, I changed the PGO instrumentation counter for a "do" loop to not<br>
include the fall-through count. That fall-through count is included later, b<br>
it means that this assertion may fail for "do" loops.<br>
<br>
Modified:<br>
cfe/trunk/lib/CodeGen/CodeGenPGO.h<br>
<br>
Modified: cfe/trunk/lib/CodeGen/CodeGenPGO.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CodeGenPGO.h?rev=202437&r1=202436&r2=202437&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CodeGenPGO.h?rev=202437&r1=202436&r2=202437&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/CodeGen/CodeGenPGO.h (original)<br>
+++ cfe/trunk/lib/CodeGen/CodeGenPGO.h Thu Feb 27 15:59:17 2014<br>
@@ -186,7 +186,6 @@ public:<br>
/// within the region. The adjusted count, then, is the value of the counter<br>
/// at the end of the region.<br>
uint64_t getAdjustedCount() const {<br>
- assert((Adjust > 0 || (uint64_t)(-Adjust) <= Count) && "Negative count");<br>
return Count + Adjust;<br>
}<br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>
</blockquote></div><br></div></body></html>