[PATCH] MS ABI: Improve selection of an inheritance model

Reid Kleckner rnk at google.com
Thu Jan 16 11:23:34 PST 2014


  LGTM


================
Comment at: lib/Sema/SemaCast.cpp:1786
@@ +1785,3 @@
+      // haven't yet.
+      Self.RequireCompleteType(OpRange.getBegin(), SrcType, 0);
+      Self.RequireCompleteType(OpRange.getBegin(), DestType, 0);
----------------
OK, seems like Sema is supposed to RequireCompleteType before asking for the size.


http://llvm-reviews.chandlerc.com/D2548

BRANCH
  PR18479

ARCANIST PROJECT
  clang



More information about the cfe-commits mailing list