[PATCH] MS ABI: Improve selection of an inheritance model

Aaron Ballman aaron at aaronballman.com
Thu Jan 16 11:14:27 PST 2014


Attribute-related functionality LGTM! So does the rest, but I'll defer
to Reid's judgement there.

~Aaron

On Thu, Jan 16, 2014 at 2:04 PM, David Majnemer
<david.majnemer at gmail.com> wrote:
>     - Add a test-case for PR18479.
>     - Address review feedback.
>     - Address further review comments.
>     - Update patch to use the latest Attr changes.
>
> Hi rnk, rsmith,
>
> http://llvm-reviews.chandlerc.com/D2548
>
> CHANGE SINCE LAST DIFF
>   http://llvm-reviews.chandlerc.com/D2548?vs=6490&id=6492#toc
>
> BRANCH
>   PR18479
>
> ARCANIST PROJECT
>   clang
>
> Files:
>   include/clang/AST/DeclCXX.h
>   include/clang/AST/Type.h
>   include/clang/Basic/Attr.td
>   lib/AST/MicrosoftCXXABI.cpp
>   lib/AST/Type.cpp
>   lib/CodeGen/MicrosoftCXXABI.cpp
>   lib/Sema/SemaCast.cpp
>   lib/Sema/SemaType.cpp
>   test/SemaCXX/microsoft-abi-ptm.cpp
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>



More information about the cfe-commits mailing list