[PATCH] Improve error message when a stale PCH dependency is encountered

Ben Langmuir blangmuir at apple.com
Thu Jan 16 11:04:57 PST 2014


On Jan 16, 2014, at 10:15 AM, Argyrios Kyrtzidis <kyrtzidis at apple.com> wrote:
> 
> Very nice! I like the import stack in the notes.
> Could you also add a note saying something like "please rebuild the precompiled header ’foo.h.pch’” ?

Done.  I emitted it conditionally upon Diags.isDiagnosticsInFlight().  I wasn’t sure if that’s desired, but it seems to be the way the other notes are being emitted in this file so I did it too.

Ben

-------------- next part --------------
A non-text attachment was scrubbed...
Name: pch-error.patch
Type: application/octet-stream
Size: 3728 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140116/69bfbcb6/attachment.obj>


More information about the cfe-commits mailing list