[PATCH] Improve error message when a stale PCH dependency is encountered

[Argyrios Kyrtzidis]

On Jan 15, 2014, at 5:07 PM, Ben Langmuir <blangmuir at apple.com> wrote:

> This patch changes which PCH file is displayed in the error that you get when a PCH dependency is modified after the PCH is built.  Now the ‘top-level’ PCH file is shown as the culprit.  When the PCH imports a module, the previous behavior was to blame the pcm file in the module, which is misleading because fixing the pcm will just cause the PCH to fail because it refers to a stale location, whereas rebuilding the pch will also automatically rebuild the module.

Very nice! I like the import stack in the notes.
Could you also add a note saying something like "please rebuild the precompiled header ’foo.h.pch’” ?

> 
> <pch-error.patch>_______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits