r198858 - Disable LeakSanitizer in TableGen binaries, see PR18325

Richard Smith richardsmith at google.com
Mon Jan 13 13:47:21 PST 2014


On Mon, Jan 13, 2014 at 8:03 AM, Alp Toker <alp at nuanti.com> wrote:

>
> On 13/01/2014 15:02, Kostya Serebryany wrote:
>
>> Alp, others,
>>
>> Now that there is no urgent issue I'd like to return to the discussion
>> about names with "__" prefix in sanitizer run-times.
>>
>
> If you're OK to conditionalize the code so it's only defined in sanitizer
> builds, that's fine and as Sean pointed out there's already plenty of
> precedent -- it's what every software project does to define "__" prefixed
> weak link functions like libc malloc hooks.
>

This discussion is so vastly far from the best use of any of our time.
Let's just restore the name we had before and wrap the definition in
__has_feature(leak_sanitizer). I think that will make everyone happy. OK?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140113/89d7a264/attachment.html>


More information about the cfe-commits mailing list