r197916 - remove dead code.

Eric Christopher echristo at gmail.com
Fri Dec 27 14:05:24 PST 2013


(FWIW looking at the code it's obvious, but not in the diff that gets
sent out blah blah blah).

-eric

On Fri, Dec 27, 2013 at 2:03 PM, Eric Christopher <echristo at gmail.com> wrote:
> Can you make sure to explain why it's dead in the commit messages (for now a
> followup to the commit would be nice).
>
> Thanks!
>
> -eric
>
> On Mon Dec 23 2013 at 11:17:10 AM, Adrian Prantl <aprantl at apple.com> wrote:
>>
>> Author: adrian
>> Date: Mon Dec 23 13:10:57 2013
>> New Revision: 197916
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=197916&view=rev
>> Log:
>> remove dead code.
>>
>> Modified:
>>     cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
>>
>> Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGDebugInfo.cpp?rev=197916&r1=197915&r2=197916&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/lib/CodeGen/CGDebugInfo.cpp (original)
>> +++ cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Mon Dec 23 13:10:57 2013
>> @@ -1470,7 +1470,7 @@ llvm::DIType CGDebugInfo::CreateType(con
>>         !RD->isCompleteDefinitionRequired() &&
>> CGM.getLangOpts().CPlusPlus) ||
>>        // If the class is dynamic, only emit a declaration. A definition
>> will be
>>        // emitted whenever the vtable is emitted.
>> -      (CXXDecl && CXXDecl->hasDefinition() && CXXDecl->isDynamicClass())
>> || T) {
>> +      (CXXDecl && CXXDecl->hasDefinition() && CXXDecl->isDynamicClass()))
>> {
>>      llvm::DIDescriptor FDContext =
>>        getContextDescriptor(cast<Decl>(RD->getDeclContext()));
>>      if (!T)
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits



More information about the cfe-commits mailing list