r197920 - Document the Message parameter of getCustomDiagID()
Alp Toker
alp at nuanti.com
Mon Dec 23 13:00:35 PST 2013
Author: alp
Date: Mon Dec 23 15:00:35 2013
New Revision: 197920
URL: http://llvm.org/viewvc/llvm-project?rev=197920&view=rev
Log:
Document the Message parameter of getCustomDiagID()
A lot of callers have been using this facility incorrectly.
Modified:
cfe/trunk/include/clang/Basic/Diagnostic.h
cfe/trunk/lib/Basic/DiagnosticIDs.cpp
Modified: cfe/trunk/include/clang/Basic/Diagnostic.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/Diagnostic.h?rev=197920&r1=197919&r2=197920&view=diff
==============================================================================
--- cfe/trunk/include/clang/Basic/Diagnostic.h (original)
+++ cfe/trunk/include/clang/Basic/Diagnostic.h Mon Dec 23 15:00:35 2013
@@ -591,6 +591,9 @@ public:
///
/// If this is the first request for this diagnostic, it is registered and
/// created, otherwise the existing ID is returned.
+ ///
+ /// \param Message A fixed diagnostic format string that will be hashed and
+ /// mapped to a unique DiagID.
unsigned getCustomDiagID(Level L, StringRef Message) {
return Diags->getCustomDiagID((DiagnosticIDs::Level)L, Message);
}
Modified: cfe/trunk/lib/Basic/DiagnosticIDs.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/DiagnosticIDs.cpp?rev=197920&r1=197919&r2=197920&view=diff
==============================================================================
--- cfe/trunk/lib/Basic/DiagnosticIDs.cpp (original)
+++ cfe/trunk/lib/Basic/DiagnosticIDs.cpp Mon Dec 23 15:00:35 2013
@@ -311,6 +311,9 @@ DiagnosticIDs::~DiagnosticIDs() {
/// getCustomDiagID - Return an ID for a diagnostic with the specified message
/// and level. If this is the first request for this diagnostic, it is
/// registered and created, otherwise the existing ID is returned.
+///
+/// \param Message A fixed diagnostic format string that will be hashed and
+/// mapped to a unique DiagID.
unsigned DiagnosticIDs::getCustomDiagID(Level L, StringRef Message) {
if (CustomDiagInfo == 0)
CustomDiagInfo = new diag::CustomDiagInfo();
More information about the cfe-commits
mailing list