Patch to fix Clang armv7 IRGen crash - PR17759

jahanian fjahanian at apple.com
Tue Dec 3 09:15:21 PST 2013


Thanks for the review. In r196296.
-Fariborz

On Dec 2, 2013, at 8:11 PM, Richard Smith <richard at metafoo.co.uk> wrote:

> Looks good, thanks.
> 
> On 2 Dec 2013 17:41, "jahanian" <fjahanian at apple.com> wrote:
> 
> On Dec 2, 2013, at 4:22 PM, Richard Smith <richard at metafoo.co.uk> wrote:
> 
>> This is a frontend bug, not an IRGen bug; the test case is ill-formed. "return;" can be used in a constructor or destructor, but "return <expression-with-type-void>;" cannot.
>> 
> 
> Ok thanks. Sema patch is attached. Please review.
> - Fariborz
> 
> 
> 	
> 
> 
>> 
>> On Mon, Dec 2, 2013 at 4:09 PM, jahanian <fjahanian at apple.com> wrote:
>> This patch fixes a crash when generating IRGen for armv7 which has ABI of
>> implicit return of 'this' for constructors. Please review.
>> // rdar://15366494
>> - fariborz
>> 
>> 
>> 
>> 
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>> 
>> 
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131203/00930725/attachment.html>


More information about the cfe-commits mailing list