<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Thanks for the review. In <font face="Menlo"><span style="font-size: 11px;">r</span></font><span style="font-family: Menlo; font-size: 11px;">196296.</span><div><font face="Menlo"><span style="font-size: 11px;">-Fariborz</span></font></div><div><font face="Menlo"><span style="font-size: 11px;"><br></span></font><div><div>On Dec 2, 2013, at 8:11 PM, Richard Smith <<a href="mailto:richard@metafoo.co.uk">richard@metafoo.co.uk</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><p dir="ltr">Looks good, thanks.</p>
<div class="gmail_quote">On 2 Dec 2013 17:41, "jahanian" <<a href="mailto:fjahanian@apple.com">fjahanian@apple.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word"><br><div><div>On Dec 2, 2013, at 4:22 PM, Richard Smith <<a href="mailto:richard@metafoo.co.uk" target="_blank">richard@metafoo.co.uk</a>> wrote:</div><br><blockquote type="cite"><div dir="ltr">
This is a frontend bug, not an IRGen bug; the test case is ill-formed. "return;" can be used in a constructor or destructor, but "return <expression-with-type-void>;" cannot.<br></div>
<div class="gmail_extra"><br></div></blockquote><div><br></div>Ok thanks. Sema patch is attached. Please review.</div><div>- Fariborz</div><div><br></div><div><br></div><div><span style="white-space:pre-wrap"> </span></div>
</div>
<br><div style="word-wrap:break-word"><div><br><blockquote type="cite"><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Dec 2, 2013 at 4:09 PM, jahanian <span dir="ltr"><<a href="mailto:fjahanian@apple.com" target="_blank">fjahanian@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word">This patch fixes a crash when generating IRGen for armv7 which has ABI of<div><div style="margin:0px;font-size:11px;font-family:Menlo">implicit return of 'this' for constructors. Please review.</div>
</div><div style="margin:0px;font-size:11px;font-family:Menlo">// <a>rdar://15366494</a></div><div style="margin:0px;font-size:11px;font-family:Menlo">- fariborz</div><div style="margin:0px;font-size:11px;font-family:Menlo">
<br></div><div style="margin:0px;font-size:11px;font-family:Menlo"><br></div><div style="margin:0px;font-size:11px;font-family:Menlo"></div></div>
<br><div style="word-wrap:break-word"><div style="margin:0px;font-size:11px;font-family:Menlo"></div></div>
<br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div>
</blockquote></div><br></div>
<br></blockquote></div>
</blockquote></div><br></div></body></html>