[PATCH] PR9537: Do not warn about unknown pragmas with -Eonly/-M etc.

Lubos Lunak l.lunak at centrum.cz
Thu Nov 28 06:58:39 PST 2013


On Thursday 28 of November 2013, Richard Smith wrote:
> Some tiny things:
>
> +  // Ignore also all pragma in all namespaces created
> +  // in Preprocessor::RegisterBuiltinPragmas().
>
> The English in this (copy-pasted) comment is a bit awkward; can you fix it
> to something like "Also ignore all pragmas in [...]"
>
> Please also add to your testcase an instance of a #pragma we don't normally
> understand (#pragma this_pragma_does_not_exist or similar).

 Updated.

> Otherwise, LGTM, thanks!
>
> On Wed, Nov 27, 2013 at 3:57 PM, Lubos Lunak <l.lunak at centrum.cz> wrote:
> >  Hello,
> >
> >  the attached patch should fix PR9537. It is apparently necessary to
> > install
> > empty pragma handlers for all pragma namespaces that exist.
> >
> > --
> >  Lubos Lunak

-- 
 Lubos Lunak
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-do-not-warn-about-unknown-pragmas-in-modes-that-do-n.patch
Type: text/x-diff
Size: 4775 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131128/37ed1002/attachment.patch>


More information about the cfe-commits mailing list