[PATCH] PR9537: Do not warn about unknown pragmas with -Eonly/-M etc.

Richard Smith richard at metafoo.co.uk
Wed Nov 27 16:51:07 PST 2013

Some tiny things:

+  // Ignore also all pragma in all namespaces created
+  // in Preprocessor::RegisterBuiltinPragmas().

The English in this (copy-pasted) comment is a bit awkward; can you fix it
to something like "Also ignore all pragmas in [...]"

Please also add to your testcase an instance of a #pragma we don't normally
understand (#pragma this_pragma_does_not_exist or similar).

Otherwise, LGTM, thanks!

On Wed, Nov 27, 2013 at 3:57 PM, Lubos Lunak <l.lunak at centrum.cz> wrote:

>  Hello,
>  the attached patch should fix PR9537. It is apparently necessary to
> install
> empty pragma handlers for all pragma namespaces that exist.
> --
>  Lubos Lunak
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131127/4ef45f7c/attachment.html>

More information about the cfe-commits mailing list