r195529 - Revert r195526, "Remove uninstantiable constructor from DeclTemplate.h"

Kim Gräsman kim.grasman at gmail.com
Sat Nov 23 01:09:21 PST 2013


On Fri, Nov 22, 2013 at 4:51 PM, Peter Collingbourne <peter at pcc.me.uk>
> wrote:
>
> Revert r195526, "Remove uninstantiable constructor from DeclTemplate.h"
>
> It apparently causes some versions of GCC to segfault.

That's a fun surprise.

On Sat, Nov 23, 2013 at 2:35 AM, Richard Smith <richard at metafoo.co.uk> wrote:
> Could you use something like:
>
> private:
>   SpecIterator() LLVM_DELETED_FUNCTION;
>
> to both fix the original problem and avoid the gcc crash?

Good idea, new patch attached (I couldn't figure out how to update the
diff in Phabricator).

I added a FIXME explaining why the deleted ctor was necessary.

Thanks,
- Kim
-------------- next part --------------
A non-text attachment was scrubbed...
Name: decltemplate2.patch
Type: application/octet-stream
Size: 776 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131123/22605a8f/attachment.obj>


More information about the cfe-commits mailing list