r195529 - Revert r195526, "Remove uninstantiable constructor from DeclTemplate.h"

[Richard Smith]

Could you use something like:

private:
  SpecIterator() LLVM_DELETED_FUNCTION;

to both fix the original problem and avoid the gcc crash?


On Fri, Nov 22, 2013 at 4:51 PM, Peter Collingbourne <peter at pcc.me.uk>wrote:

> Author: pcc
> Date: Fri Nov 22 18:51:53 2013
> New Revision: 195529
>
> URL: http://llvm.org/viewvc/llvm-project?rev=195529&view=rev
> Log:
> Revert r195526, "Remove uninstantiable constructor from DeclTemplate.h"
>
> It apparently causes some versions of GCC to segfault.
>
> http://bb.pgr.jp/builders/cmake-clang-x86_64-linux/builds/17175/steps/build_clang/logs/stdio
>
> Modified:
>     cfe/trunk/include/clang/AST/DeclTemplate.h
>
> Modified: cfe/trunk/include/clang/AST/DeclTemplate.h
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/DeclTemplate.h?rev=195529&r1=195528&r2=195529&view=diff
>
> ==============================================================================
> --- cfe/trunk/include/clang/AST/DeclTemplate.h (original)
> +++ cfe/trunk/include/clang/AST/DeclTemplate.h Fri Nov 22 18:51:53 2013
> @@ -564,6 +564,7 @@ protected:
>      SetIteratorType SetIter;
>
>    public:
> +    SpecIterator() : SetIter() {}
>      SpecIterator(SetIteratorType SetIter) : SetIter(SetIter) {}
>
>      DeclType *operator*() const {
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131122/aa4a9c33/attachment.html>