r194969 - Remove a bad string compare from r194968

[Alp Toker]

On 18/11/2013 08:23, Chandler Carruth wrote:
>
> On Mon, Nov 18, 2013 at 12:20 AM, Manuel Klimek <klimek at google.com 
> <mailto:klimek at google.com>> wrote:
>
>     Wouldn't the right fix have been to s/"/'/g?
>

Hi Klimek,

That wouldn't help because the comparand isn't a character literal. So 
you'd get:

lib/Tooling/CompilationDatabase.cpp:274:34: error: comparison between 
pointer and integer ('const char *' and 'int')
   (__builtin_expect(!(*(End - 1) == '-c'), 0) ? __assert_rtn(__func__, 
"lib/Tooling/CompilationDatabase.cpp", 274, "*(End - 1) == '-c'") : 
(void)0);


I pinged Edwin Vane yesterday on cfe-commits so he can take a proper 
look at it.

Meanwhile removing the assertion has got the builders green.

>
> Yes.
>
> Alp, maybe reply to the commit which introduced the warning if you're 
> not sure how to fix next time?

Chandler, please grow up.

Alp.

-- 
http://www.nuanti.com
the browser experts