[PATCH] Replaced bool parameters in SkipUntil function with single bit-based parameter.

Alexey Bataev a.bataev at hotmail.com
Mon Nov 18 00:22:03 PST 2013



================
Comment at: include/clang/Parse/Parser.h:743
@@ +742,3 @@
+    StopAtSemi = 1 << 0,  /// \brief Stop skipping at semicolon
+    /// brief Stop skipping at specified token, but don't skip the token itself
+    StopBeforeMatch = 1 << 1,
----------------
Richard Smith wrote:
> Missing \ before brief. Also, please use the same style for all the comments here (put them all on the line before rather than having some before and some after the enumerator.
Fixed.

================
Comment at: include/clang/Parse/Parser.h:755
@@ -739,3 +754,3 @@
   /// SkipUntil - Read tokens until we get to the specified token, then consume
-  /// it (unless DontConsume is true).  Because we cannot guarantee that the
+  /// it (unless no flag StopBeforeMatch).  Because we cannot guarantee that the
   /// token will ever occur, this skips to the next token, or to some likely
----------------
Richard Smith wrote:
> "(unless StopBeforeMatch is specified)".
Fixed.


http://llvm-reviews.chandlerc.com/D2108



More information about the cfe-commits mailing list