[PATCH] Install libc++ headers in include/, rather than lib/

[Justin Bogner]

This is actually (very strangely) a patch against the clang tree. When
building llvm with the configure system we seem to use the Makefile in
llvm/tools/clang/runtime/libcxx/Makefile, which invokes make using the
Makefile in projects/libcxx/Makefile. Thus, both of these patches are
against clang, and the libcxx repo is untouched.

Howard Hinnant <hhinnant at apple.com> writes:
> I have no rationale for the current placement and no objection to the movement.
>
> Justin's patch against libcxx/Makefile fails to patch.
>
> Howard
>
> On Nov 15, 2013, at 11:58 AM, Rafael Espíndola
> <rafael.espindola at gmail.com> wrote:
>
>> I would love to see them in /include. I just wanted to make sure
>> Haward had a chance to comment on why it should be in /lib or if there
>> is any problems with moving them to /include.
>> 
>> Since it looks like libc++ is just matched to clang, my first
>> impression is that it is OK for one version to use /lib an the next
>> one to use /include, but I don't know a lot about the previous
>> decision in this area.
>> 
>> On 15 November 2013 11:51, Justin Bogner <mail at justinbogner.com> wrote:
>>> To be clear, these changes would change that installation path. I
>>> should've mentioned in my original email that I did speak with a few
>>> people and no one could recall a good reason these are in lib today, and
>>> that it was more logical to use the include/ dir than to update the
>>> cmake build to use lib/ as well.
>>> 
>>> Rafael Espíndola <rafael.espindola at gmail.com> writes:
>>>> On darwin the shipping clang has the headers installed in
>>>> 
>>>> /Applications/Xcode.app//Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/c++/v1/iostream
>>>> 
>>>> so it looks like this is intentional.
>>>> 
>>>> On 14 November 2013 19:09, Justin Bogner <mail at justinbogner.com> wrote:
>>>>> These two patches change the configure build system to install libc++
>>>>> headers in include/ like the cmake build system does. The second patch
>>>>> updates the search path on Darwin to work with this.