[PATCH] Install libc++ headers in include/, rather than lib/

Howard Hinnant hhinnant at apple.com
Fri Nov 15 09:20:55 PST 2013


I have no rationale for the current placement and no objection to the movement.

Justin's patch against libcxx/Makefile fails to patch.

Howard

On Nov 15, 2013, at 11:58 AM, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:

> I would love to see them in /include. I just wanted to make sure
> Haward had a chance to comment on why it should be in /lib or if there
> is any problems with moving them to /include.
> 
> Since it looks like libc++ is just matched to clang, my first
> impression is that it is OK for one version to use /lib an the next
> one to use /include, but I don't know a lot about the previous
> decision in this area.
> 
> On 15 November 2013 11:51, Justin Bogner <mail at justinbogner.com> wrote:
>> To be clear, these changes would change that installation path. I
>> should've mentioned in my original email that I did speak with a few
>> people and no one could recall a good reason these are in lib today, and
>> that it was more logical to use the include/ dir than to update the
>> cmake build to use lib/ as well.
>> 
>> Rafael EspĂ­ndola <rafael.espindola at gmail.com> writes:
>>> On darwin the shipping clang has the headers installed in
>>> 
>>> /Applications/Xcode.app//Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/c++/v1/iostream
>>> 
>>> so it looks like this is intentional.
>>> 
>>> On 14 November 2013 19:09, Justin Bogner <mail at justinbogner.com> wrote:
>>>> These two patches change the configure build system to install libc++
>>>> headers in include/ like the cmake build system does. The second patch
>>>> updates the search path on Darwin to work with this.





More information about the cfe-commits mailing list