[PATCH] Replaced bool parameters in SkipUntil function with single bit-based parameter.

[Richard Smith]

On Thu, Nov 7, 2013 at 11:23 PM, Alp Toker <alp at nuanti.com> wrote:

>
> "Dont" without the apostrophe reads more like "Donut" than anything else.
>
> I know it was like that before your patch, but let's go with
> s/DontConsume/NoConsume/g
>

Maybe even StopBeforeMatch?

... and that makes it a bit more obvious that this generalizes further.
Just a strawman, but:

  SkipTokens(StopAt(tok::code_completion), StopAt(tok::semi),
StopAfter(tok::r_paren));

Otherwise this patch is starting to look seriously good :-)
>
> Alp.
>
> On 08/11/2013 06:17, Alexey Bataev wrote:
> >   Fixes after Richard Smith review.
> >
> > Hi doug.gregor, cbergstrom, hfinkel,
> >
> > http://llvm-reviews.chandlerc.com/D2108
> >
> > CHANGE SINCE LAST DIFF
> >   http://llvm-reviews.chandlerc.com/D2108?vs=5392&id=5405#toc
> >
> > Files:
> >   include/clang/Parse/Parser.h
> >   lib/Parse/ParseTentative.cpp
> >   lib/Parse/ParseInit.cpp
> >   lib/Parse/ParseDecl.cpp
> >   lib/Parse/ParseTemplate.cpp
> >   lib/Parse/ParseObjc.cpp
> >   lib/Parse/ParseExpr.cpp
> >   lib/Parse/ParseCXXInlineMethods.cpp
> >   lib/Parse/ParseStmt.cpp
> >   lib/Parse/ParseDeclCXX.cpp
> >   lib/Parse/ParseOpenMP.cpp
> >   lib/Parse/ParseExprCXX.cpp
> >   lib/Parse/Parser.cpp
> >
> >
> > _______________________________________________
> > cfe-commits mailing list
> > cfe-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
> --
> http://www.nuanti.com
> the browser experts
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131107/7eb5bbf3/attachment.html>