<div dir="ltr">On Thu, Nov 7, 2013 at 11:23 PM, Alp Toker <span dir="ltr"><<a href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
"Dont" without the apostrophe reads more like "Donut" than anything else.<br>
<br>
I know it was like that before your patch, but let's go with<br>
s/DontConsume/NoConsume/g<br></blockquote><div><br></div><div>Maybe even StopBeforeMatch?</div><div><br></div><div>... and that makes it a bit more obvious that this generalizes further. Just a strawman, but:</div><div><br>
</div><div>  SkipTokens(StopAt(tok::code_completion), StopAt(tok::semi), StopAfter(tok::r_paren));</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

Otherwise this patch is starting to look seriously good :-)<br>
<span class="HOEnZb"><font color="#888888"><br>
Alp.<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
On 08/11/2013 06:17, Alexey Bataev wrote:<br>
>   Fixes after Richard Smith review.<br>
><br>
> Hi doug.gregor, cbergstrom, hfinkel,<br>
><br>
> <a href="http://llvm-reviews.chandlerc.com/D2108" target="_blank">http://llvm-reviews.chandlerc.com/D2108</a><br>
><br>
> CHANGE SINCE LAST DIFF<br>
>   <a href="http://llvm-reviews.chandlerc.com/D2108?vs=5392&id=5405#toc" target="_blank">http://llvm-reviews.chandlerc.com/D2108?vs=5392&id=5405#toc</a><br>
><br>
> Files:<br>
>   include/clang/Parse/Parser.h<br>
>   lib/Parse/ParseTentative.cpp<br>
>   lib/Parse/ParseInit.cpp<br>
>   lib/Parse/ParseDecl.cpp<br>
>   lib/Parse/ParseTemplate.cpp<br>
>   lib/Parse/ParseObjc.cpp<br>
>   lib/Parse/ParseExpr.cpp<br>
>   lib/Parse/ParseCXXInlineMethods.cpp<br>
>   lib/Parse/ParseStmt.cpp<br>
>   lib/Parse/ParseDeclCXX.cpp<br>
>   lib/Parse/ParseOpenMP.cpp<br>
>   lib/Parse/ParseExprCXX.cpp<br>
>   lib/Parse/Parser.cpp<br>
><br>
><br>
</div></div><div class="im HOEnZb">> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br>
</div><div class="HOEnZb"><div class="h5">--<br>
<a href="http://www.nuanti.com" target="_blank">http://www.nuanti.com</a><br>
the browser experts<br>
<br>
</div></div></blockquote></div><br></div></div>