[clang-tools-extra] r192713 - ModuleAssistant: Fix warning, don't return bool as a pointer.

[Thompson, John]

Yep, sorry, I changed the return type, but missed this return.  Curiously I didn't get a warning in VC++ or gcc.

From: cfe-commits-bounces at cs.uiuc.edu [mailto:cfe-commits-bounces at cs.uiuc.edu] On Behalf Of David Blaikie
Sent: Tuesday, October 15, 2013 9:44 AM
To: Will Dietz
Cc: llvm cfe
Subject: Re: [clang-tools-extra] r192713 - ModuleAssistant: Fix warning, don't return bool as a pointer.



On Tue, Oct 15, 2013 at 8:45 AM, Will Dietz <wdietz2 at illinois.edu<mailto:wdietz2 at illinois.edu>> wrote:
Author: wdietz2
Date: Tue Oct 15 10:45:00 2013
New Revision: 192713

URL: http://llvm.org/viewvc/llvm-project?rev=192713&view=rev
Log:
ModuleAssistant: Fix warning, don't return bool as a pointer.

Was this caught by a warning? If not, Clang should perhaps grow one - last I checked I don't think it caught this. (though I'll grant you it might not find many 'bugs', but some amount of confusion)


No functionality change intended.

Modified:
    clang-tools-extra/trunk/modularize/ModuleAssistant.cpp

Modified: clang-tools-extra/trunk/modularize/ModuleAssistant.cpp
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/modularize/ModuleAssistant.cpp?rev=192713&r1=192712&r2=192713&view=diff
==============================================================================
--- clang-tools-extra/trunk/modularize/ModuleAssistant.cpp (original)
+++ clang-tools-extra/trunk/modularize/ModuleAssistant.cpp Tue Oct 15 10:45:00 2013
@@ -219,7 +219,7 @@ static Module *loadModuleDescriptions(
        I != E; ++I) {
     // Add as a module.
     if (!addModuleDescription(RootModule, *I, HeaderPrefix, Dependencies))
-      return false;
+      return NULL;
   }

   return RootModule;


_______________________________________________
cfe-commits mailing list
cfe-commits at cs.uiuc.edu<mailto:cfe-commits at cs.uiuc.edu>
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131015/6c9863e1/attachment.html>