<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Yep, sorry, I changed the return type, but missed this return. Curiously I didn’t get a warning in VC++ or gcc.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> cfe-commits-bounces@cs.uiuc.edu [mailto:cfe-commits-bounces@cs.uiuc.edu]
<b>On Behalf Of </b>David Blaikie<br>
<b>Sent:</b> Tuesday, October 15, 2013 9:44 AM<br>
<b>To:</b> Will Dietz<br>
<b>Cc:</b> llvm cfe<br>
<b>Subject:</b> Re: [clang-tools-extra] r192713 - ModuleAssistant: Fix warning, don't return bool as a pointer.<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><o:p> </o:p></p>
<div>
<p class="MsoNormal">On Tue, Oct 15, 2013 at 8:45 AM, Will Dietz <<a href="mailto:wdietz2@illinois.edu" target="_blank">wdietz2@illinois.edu</a>> wrote:<o:p></o:p></p>
<p class="MsoNormal">Author: wdietz2<br>
Date: Tue Oct 15 10:45:00 2013<br>
New Revision: 192713<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=192713&view=rev" target="_blank">
http://llvm.org/viewvc/llvm-project?rev=192713&view=rev</a><br>
Log:<br>
ModuleAssistant: Fix warning, don't return bool as a pointer.<o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Was this caught by a warning? If not, Clang should perhaps grow one - last I checked I don't think it caught this. (though I'll grant you it might not find many 'bugs', but some amount of confusion)<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal"><br>
No functionality change intended.<br>
<br>
Modified:<br>
clang-tools-extra/trunk/modularize/ModuleAssistant.cpp<br>
<br>
Modified: clang-tools-extra/trunk/modularize/ModuleAssistant.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/modularize/ModuleAssistant.cpp?rev=192713&r1=192712&r2=192713&view=diff" target="_blank">
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/modularize/ModuleAssistant.cpp?rev=192713&r1=192712&r2=192713&view=diff</a><br>
==============================================================================<br>
--- clang-tools-extra/trunk/modularize/ModuleAssistant.cpp (original)<br>
+++ clang-tools-extra/trunk/modularize/ModuleAssistant.cpp Tue Oct 15 10:45:00 2013<br>
@@ -219,7 +219,7 @@ static Module *loadModuleDescriptions(<br>
I != E; ++I) {<br>
// Add as a module.<br>
if (!addModuleDescription(RootModule, *I, HeaderPrefix, Dependencies))<br>
- return false;<br>
+ return NULL;<br>
}<br>
<br>
return RootModule;<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><o:p></o:p></p>
</blockquote>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
</div>
</body>
</html>