[patch] [libcxx] random.cpp not quite right for vc

[Yaron Keren]

Hi,

The patch from the second link does have the #if !defined(_WIN32).
In any case your patch is just as good :-).

I think what happened here is that the original thread
http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20131007/090432.html
was forked to a new thread starting here
http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20131007/090561.html
and then the wrong patch taken from the original thread.

Marshall suggested and I created an account in the LLVM Phabricator
http://llvm-reviews.chandlerc.com/
 and will use it in addition to the mailing list.

Yaron





2013/10/10 G M <gmisocpp at gmail.com>

> Hi Marshall
>
> The random patch doesn't seem to have the fix I suggested in my code
> review here:
>
> http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20131007/090561.html
>
> Yaron  mentioned he'd added it here:
>
> http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20131007/090566.html
>
> I don't know if you applied an old revision of his patch or yaron forgot
> to add my suggestions after all but the attached patch makes it work for me
> with MSVC.
>
> Thanks
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131010/cebe112a/attachment.html>