[patch] [libcxx] random.cpp not quite right for vc

G M gmisocpp at gmail.com
Wed Oct 9 20:41:09 PDT 2013


Hi Marshall

The random patch doesn't seem to have the fix I suggested in my code review
here:
http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20131007/090561.html

Yaron  mentioned he'd added it here:
http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20131007/090566.html

I don't know if you applied an old revision of his patch or yaron forgot to
add my suggestions after all but the attached patch makes it work for me
with MSVC.

Thanks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131010/c7b408ca/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: random.cpp.diff
Type: application/octet-stream
Size: 363 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131010/c7b408ca/attachment.obj>


More information about the cfe-commits mailing list