[PATCH] Files in a compilation database using relative paths are not being transformed

Ariel Bernal ariel.j.bernal at intel.com
Fri Oct 4 19:45:59 PDT 2013


  @revane sure, I'll rename those files files.


================
Comment at: clang-modernize/Core/Transform.cpp:102-105
@@ +101,6 @@
+
+  llvm::SmallString<256> FilePath(Filename);
+  llvm::error_code EC = llvm::sys::fs::make_absolute(FilePath);
+  assert(!EC && "File path can't be made absolute");
+  (void) EC;
+
----------------
Edwin Vane wrote:
> Wouldn't it be better to do this once per source file in ClangModernizer.cpp instead of once per source per transform here?
No problem, but I'm not convinced that this is the right approach, if we move the YAML files to a folder this will go away.


http://llvm-reviews.chandlerc.com/D1837



More information about the cfe-commits mailing list