[PATCH] Files in a compilation database using relative paths are not being transformed

Edwin Vane edwin.vane at intel.com
Fri Oct 4 13:37:53 PDT 2013


  Could you expand "rel" to relative wherever it appears? LLVM style is shorthand-averse.


================
Comment at: clang-modernize/Core/Transform.cpp:102-105
@@ +101,6 @@
+
+  llvm::SmallString<256> FilePath(Filename);
+  llvm::error_code EC = llvm::sys::fs::make_absolute(FilePath);
+  assert(!EC && "File path can't be made absolute");
+  (void) EC;
+
----------------
Wouldn't it be better to do this once per source file in ClangModernizer.cpp instead of once per source per transform here?


http://llvm-reviews.chandlerc.com/D1837



More information about the cfe-commits mailing list