chrono libcxx msvcrt patch slight revision

[G M]

It provides a compile time warning AND a runtime error.
I think this is better than not compiling at all until someone provides an
implementation.

Once things compile (and we are quite close now) we can then look at how
existing code runs on Windows and linker errors once we get a clean build.

And it's not like the code isn't warning as a compile time. It's the best
of both worlds not just one.


On Sat, Oct 5, 2013 at 10:09 AM, Howard Hinnant <howard.hinnant at gmail.com>wrote:

> On Sep 21, 2013, at 4:08 PM, G M <gmisocpp at gmail.com> wrote:
>
> > Slight revision to prior chrono patch: Added _LIBCPP_NORETURN.
> > (Note dependant upon #warning patch presented previously).
> > <chrono.cpp.diff>_______________________________________________
> > cfe-commits mailing list
> > cfe-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
> Question for those interested in libc++ on Windows:
>
> I generally prefer my errors to come at compile time, or at least link
> time, rather than run time.  This patch delays until runtime the fact that
> the chrono clocks are not implemented.  Is that really what the Windows
> porters want?  If so, I'll commit this patch.  I just wanted to ask first,
> as it is not what I did for Apple platforms.
>
> Howard
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131005/a70e5f1c/attachment.html>